Center constant data when fitting. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see, that makes sense. Since we have to pick an arbitrary amount to add to the min/max, I agree that +/-0.5 for a single unit span is probably the most logical choice. Merging. |
phkehl
pushed a commit
to phkehl/implot
that referenced
this pull request
Dec 21, 2020
Co-authored-by: Yan Zaretskiy <yzaretskiy@stoneridgetechnology.com>
Ben1138
pushed a commit
to Ben1138/implot
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Yan Zaretskiy <yzaretskiy@stoneridgetechnology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely simple fix, I am open to changing it. The reason the current logic does not work is that if the
plot.XAxis.Range.Maxhappens to be zero, nothing will happen. I reasoned that we don't really need to shift ranges by some percentage of the max value, we just center it.