Fix for allowing core imgui to use typed ImGuiCol / ImGuiStyleVar enums. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been experimenting with making some (non-flags) enums use typed C++ enums.
For a few types like
ImGuiKeyit seemed quite worthwhile are they are useful to see in debugger without a extra cast.I realized
ImGuiColandImGuiStyleVar, although less useful, could similarly be strongly typed.I haven't push the changes to core lib as I noticed it would break build on ImPlot.
Enclosed a few fixes to ensure it should work before and after.
Note the PushStyleVar() signature even used an incorrect type but it didn't matter there.