Embrace 'nullptr' #465
Merged
Embrace 'nullptr' #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! @epezent I took the liberty to merge this. I contemplated adding the warning pragma/push warning disable as the big files in imgui codebase, but my main reason for not applying the same in imgui codebase don't apply nearly as much here so I thought it would be sane to simply go ahead and use nullptr. |
|
Thanks Omar! |
azonenberg
pushed a commit
to ngscopeclient/implot
that referenced
this pull request
Aug 16, 2023
Ben1138
pushed a commit
to Ben1138/implot
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This PR is the next step of a multi-codebase crusade against using zero as a null pointer constant. I have made a PR for Imgui with similar changes.