Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAssistant training changes [not intended for merging] #31

Closed
wants to merge 60 commits into from

Conversation

andreaskoepf
Copy link
Contributor

@andreaskoepf andreaskoepf commented Aug 15, 2023

This PR is for informational purposes to show the diff of local changes that I made for training on Open-Assistant data. Not intended for merge.

The content of the OA folder has now become a PR (LAION-AI/Open-Assistant#3654), it does not contain dependencies to megatron code (I created slightly modified copies of indexed_dataset.py and tokenizer.py to remove dependencies) but it is dependent on the model_training module of Open-Assistant.

Main changes I made which have not bee merged:

  • modified finetuning.py (dataset collator, variable length sequences, loss masking)
  • created simple InstructionDataset class

Please let me know what you think could become valuable parts for the main project. I would be happy to create a clean PR for it.

@andreaskoepf
Copy link
Contributor Author

Great to see that most of the changes are now already part of the main repo. Once #40 has been merged this PR can be closed.

@andreaskoepf andreaskoepf force-pushed the local_changes branch 2 times, most recently from 32b421b to b349025 Compare August 24, 2023 22:00
@andreaskoepf andreaskoepf force-pushed the local_changes branch 2 times, most recently from 460f107 to 9f21967 Compare August 25, 2023 10:29
@andreaskoepf
Copy link
Contributor Author

Closing this as Instruction Tuning PR is now ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant