Move to new style of build definition. #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a required step to migration to Sbt 1, but it’s valuable on its own. I find the `.value` based syntax a lot clearer than the old (deprecated) operator syntax. This commit doesn’t change semantics of the build.
dragos
commented
Apr 26, 2018
| gccKey := gccTask.value, | ||
| z3Key := z3Task.value, | ||
| Keys.`package` in Compile := packageTask.value, | ||
| unmanagedJars in Compile += Attributed.blank(z3JarFile), |
There was a problem hiding this comment.
I think this line doesn't work as intended (but it's the same as before): the z3JarFile is just a string, and if the Z3 project wasn't compiled yet, unamangedJars will contain the right path to com.microsoft.z3.jar but the file won't be there, and compilation will simply fail. It would work the next time though, if somehow Z3 was built at least once and the jar is there.
A potential fix might be to make the z3JarFile be a task that dependsOn z3.value
|
I removed the old |
Merged
|
Superseded by #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a required step to migration to Sbt 1, but it’s valuable on its own. I find the
.valuebased syntax a lot clearer than the old (deprecated) operator syntax.This commit doesn’t change semantics of the build.