Improve equivalence checking #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuncak
requested review from
mario-bucev,
jad-hamza and
samarion
and removed request for
mario-bucev and
jad-hamza
|
@mario-bucev @samarion : Any chance you could take a quick look? Equivalence checking is already in master; this PR improves it. Most changes are localized in that phase and I we do not necessarily need a detailed review of that one; I suggest you focus on any possible interference (my quick check indicates this is minimal). |
|
The CI is not happy, let us spank it a bit |
|
Now it's back to happy |
|
@vkuncak Can we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to equivalence checking phase, including: function call matching, conditional equivalence (--norm option), and user-provided test generators (mkTest annotation)