Add missing dropVCs annotation in AntiAliasing
#1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-bucev
force-pushed
the
antialiasing-add-drop-vcs
branch
from
cfa8b2e
to
a077326
Compare
mario-bucev
force-pushed
the
antialiasing-add-drop-vcs
branch
from
a077326
to
754bc24
Compare
vkuncak
approved these changes
Feb 29, 2024
| // | ||
| // var thiss: BoundedCounterContainer = thiss | ||
| // ({ | ||
| // var res: (Unit, BoundedCounterContainer) = tryAdd(thiss, i) |
There was a problem hiding this comment.
This looks like the BoundedCounter case class is not considered sealed. But in the benchmark it should be, right, at least in Scala 3?
There was a problem hiding this comment.
I am just surprised about the need for this dynamic class dispatch resolution in first place.
mario-bucev
force-pushed
the
antialiasing-add-drop-vcs
branch
from
754bc24
to
aed89cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there was an already existing
@DropVCsannotation that wrapped the expression, but in some instances the VC for class invariant was still being generated (even though it should not).Note that removing the
finalmakes verification pass, so this missing@DropVCsis certainly an oversight.The
ClassReconstructionsample showcases this.