Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#643 fixes #645

Merged
merged 4 commits into from
Mar 7, 2024
Merged

#643 fixes #645

merged 4 commits into from
Mar 7, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Mar 5, 2024

I merged #643 a bit fast without waiting for @JulienVig review. here goes the fixes related to it.

@tharvik tharvik self-assigned this Mar 5, 2024
@tharvik tharvik mentioned this pull request Mar 5, 2024
@tharvik tharvik force-pushed the 643-fixes-tharvik branch 4 times, most recently from d238331 to 0ab29c2 Compare March 6, 2024 16:35
@tharvik tharvik marked this pull request as ready for review March 6, 2024 19:10
@tharvik tharvik requested a review from JulienVig March 6, 2024 19:10
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, no change required!

cli/src/cli.ts Show resolved Hide resolved
docs/examples/package.json Show resolved Hide resolved
docs/examples/training.ts Outdated Show resolved Hide resolved
@tharvik tharvik force-pushed the 643-fixes-tharvik branch from a43e819 to 91fc143 Compare March 7, 2024 13:44
@tharvik tharvik merged commit 37e8412 into develop Mar 7, 2024
23 checks passed
@tharvik tharvik deleted the 643-fixes-tharvik branch March 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants