Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Missing workflow in API #195

Open
3 tasks
DanielVoogsgerd opened this issue Nov 13, 2024 · 2 comments
Open
3 tasks

Tracking: Missing workflow in API #195

DanielVoogsgerd opened this issue Nov 13, 2024 · 2 comments
Labels
bug Something isn't working tracking-issue A meta-issue containing links to other issues describing -and keeping track of- a full feature.
Milestone

Comments

@DanielVoogsgerd
Copy link
Member

DanielVoogsgerd commented Nov 13, 2024

Since the introduction of the policy reasoner, various functions need to provide a workflow to the registry in order to retrieve data. The problem is that some interfaces cannot infer this information with the current API. Therefore, the API has to change. This is a tracking issue for the interfaces that still need to change.

  • brane-cli: download_result
  • brane-cli-c: vm_process
  • brane-cli: download_data

All of these should be fixed before we can create a 4.0.0 release, download_result needs to be fixed for the basic functionality of datasets to work again.

@DanielVoogsgerd DanielVoogsgerd added the bug Something isn't working label Nov 13, 2024
@DanielVoogsgerd DanielVoogsgerd added this to the 4.0.0 milestone Nov 13, 2024
@DanielVoogsgerd DanielVoogsgerd added the tracking-issue A meta-issue containing links to other issues describing -and keeping track of- a full feature. label Nov 14, 2024
@Lut99
Copy link
Member

Lut99 commented Nov 25, 2024

API -> brane-api?

@DanielVoogsgerd
Copy link
Member Author

API -> brane-api?

No, just the abstract term. The brane-reg download-data api requires a workflow. If you look at the callers of that api and then bubble that requirement up the call stack you basically end up at these user entrypoints/api-calls where we don't prompt the user for the required information to complete the request now that we have the policy reasoner.

So in order to resolve this, we have to either require or infer that data so we can make a valid brane-reg api call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracking-issue A meta-issue containing links to other issues describing -and keeping track of- a full feature.
Projects
None yet
Development

No branches or pull requests

2 participants