fix(cli): Implement downloading of assets with usecases #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1412,78 +1412,86 @@ | |||
| /// | |||
| /// # Panics | |||
| /// This function may panic if the input `vm` or `result` pointed to a NULL-pointer, or if `data_dir` did not point to a valid UTF-8 string. | |||
| /// | |||
| // TODO: Resolve this problem | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| return Err(DataError::UnavailableDataset { name, locs: info.access.keys().cloned().collect() }); | ||
| }, | ||
| } | ||
| // TODO: We need to generate a minimal workflow to only check if an download is |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -152,6 +152,7 @@ | |||
| } | |||
|
|
|||
| // Load it | |||
| // FIXME: The store should not fail if a single dataset is not parsible | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay this started out as providing the
DownloadAssetRequestto the download_data api in cli, but this cascaded into a whole refactor lead by the type system. Marking this PR as draft as I have no real way of testing this right now, nor the time to do so. However, without this PR we cannot really have any workflow return a result to the cli without crashing.This also disables some functionality explicity in as specified in #195
Things still left to do: