fix: Define common interface for all reasoners #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When abstracting the reasoner. I simplified the interfaces to no_op and posix. However, doing so I broke an implicit API in the command line arguments between the different reasoners. This became apparent when I started using the reasoner in Brane.
I changed it by defining a common interface module and move the
Argumentsinto there. This should allow Brane to switch between the reasoners based only on an argument in the dockerfile without changing the api usage.Cargo fmt is failing now. This PR is formatted in the same style as the main branch using nightly 1.82. I will reformat using 1.83 after it has been merged in order to avoid conflicts.