Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow_dispatch trigger for Winget workflow #1169

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix workflow_dispatch trigger for Winget workflow #1169

merged 1 commit into from
Jun 17, 2024

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jun 17, 2024

Landing a Pull Request (PR)

I'm not sure why the release trigger did not trigger, but anyhow, I added a tag name input to the workflow_dispatch trigger to fix the workflow failure.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@epi052
Copy link
Owner

epi052 commented Jun 17, 2024

appreciate it! I ran out of time to dink with it yesterday and just left it til this morning. The plan was to manually fire it for now and figure out the release trigger later, lol.

Thanks again for the help!

@epi052 epi052 merged commit 27061eb into epi052:main Jun 17, 2024
4 checks passed
@sitiom sitiom deleted the patch-1 branch June 17, 2024 09:50
@sitiom
Copy link
Contributor Author

sitiom commented Jun 17, 2024

Now it works: https://github.com/epi052/feroxbuster/actions/runs/9545359358/job/26305946498, but it didn't create the PR since I manually created it earlier: microsoft/winget-pkgs#158049. Let's just see about it on the next release 🙂

@sitiom
Copy link
Contributor Author

sitiom commented Sep 15, 2024

You made a release without any assets? https://github.com/epi052/feroxbuster/actions/runs/10870606291

Anyways, the manual workflow_dispatch worked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants