Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics tracking #168

Merged
merged 44 commits into from
Jan 5, 2021
Merged

Add statistics tracking #168

merged 44 commits into from
Jan 5, 2021

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Dec 24, 2020

closes #179
closes #176
closes #177

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets master

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::deref_addrof
  • All existing tests pass

Documentation

  • New code is documented using doc comments
  • Documentation about your PR is included in the README, as needed

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #168 (62efbe3) into master (0c29f3d) will increase coverage by 0.41%.
The diff coverage is 95.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   93.96%   94.38%   +0.41%     
==========================================
  Files          14       14              
  Lines        3117     3439     +322     
==========================================
+ Hits         2929     3246     +317     
- Misses        188      193       +5     
Impacted Files Coverage Δ
src/scan_manager.rs 88.33% <90.38%> (-0.73%) ⬇️
src/main.rs 91.79% <90.69%> (-0.97%) ⬇️
src/statistics.rs 95.32% <95.32%> (ø)
src/scanner.rs 92.74% <98.86%> (+0.70%) ⬆️
src/banner.rs 100.00% <100.00%> (ø)
src/config.rs 97.13% <100.00%> (+0.04%) ⬆️
src/extractor.rs 96.13% <100.00%> (+1.13%) ⬆️
src/heuristics.rs 92.12% <100.00%> (+0.96%) ⬆️
src/progress.rs 100.00% <100.00%> (ø)
src/reporter.rs 90.56% <100.00%> (+1.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c29f3d...74f3761. Read the comment docs.

@epi052 epi052 changed the title bumped version to 1.11.0 auto tune scan concurrency/connection limit Dec 24, 2020
@epi052 epi052 changed the title auto tune scan concurrency/connection limit Add statistics tracking Jan 3, 2021
@epi052 epi052 merged commit 1a059ad into master Jan 5, 2021
@epi052 epi052 deleted the 123-auto-tune-scans branch January 5, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add statistics tracking for errors and other scan-related info
1 participant