Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aequetas wrapper should detect host, since handling of HTML / IFrame is different in jupyter lab, jupyter hub, and vscode. #53

Closed
gbowlin opened this issue Jul 20, 2024 · 0 comments · Fixed by #57
Assignees
Labels
bug Something isn't working

Comments

@gbowlin
Copy link
Contributor

gbowlin commented Jul 20, 2024

          While this is good for caching, and makes sure that any javascript for the new html segment gets run, it does have two drawbacks:
  1. VSCode does not support loading an IFrame source from disk - IFrame not rendered in notebook output microsoft/vscode#154722
  2. JHub requires some handling for this to propagate to jupyter lab instances - https://stackoverflow.com/questions/60257156/not-able-to-embed-jupyterlab-running-on-jupyterhub-into-an-iframe

Originally posted by @gbowlin in #41 (comment)

We can check for the host with something like examining:

import psutil
cmds = [x for  x in psutil.Process().parent().cmdline()]

and seeing if jupyterhub, jupyter-lab, or vscode-server appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant