-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use IFrames in notebooks under vscode, add support for altair plot in vscode #57
Merged
diehlbw
merged 7 commits into
epic-open-source:main
from
gbowlin:dont_use_iframes_in_vscode
Jul 29, 2024
Merged
Don't use IFrames in notebooks under vscode, add support for altair plot in vscode #57
diehlbw
merged 7 commits into
epic-open-source:main
from
gbowlin:dont_use_iframes_in_vscode
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehlbw
reviewed
Jul 29, 2024
diehlbw
reviewed
Jul 29, 2024
diehlbw
previously approved these changes
Jul 29, 2024
diehlbw
previously approved these changes
Jul 29, 2024
diehlbw
approved these changes
Jul 29, 2024
diehlbw
added a commit
to diehlbw/seismometer
that referenced
this pull request
Jul 29, 2024
diehlbw
added a commit
to diehlbw/seismometer
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #53
Description of changes
Adds the ability to detect the notebook host, so that we can change display behavior based on which host we are in. This is useful when dealing with IFrames in particular, because vscode does not allow them to render local content.
Since the Altair plot for Aequitas doesn't load well as HTML, we have used the host detection ability to choose whether or not we want to save the plot to HTML/IFrame or just display the plot as is.
Testing Instructions
Author Checklist
changelog/ISSUE.TYPE.rst
files; see changelog/README.md.