Replace altair based fairness visual with great_tables visual #99

gbowlin · 2024-10-08T15:17:19Z

Overview

Closes #77
Implements: epic-open-source/seismometer-rfcs#2

Description of changes

New Fairness Table based on great_tables that allows extension by non-binary classifier models.

Author Checklist

Linting passes; run early with pre-commit hook.
Tests added for new code and issue being fixed.
Added type annotations and full numpy-style docstrings for new methods.
Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.

…remove update to config

src/seismometer/report/fairness.py

changelog/77.feature.rst

setup.cfg

src/seismometer/report/fairness.py

Co-authored-by: diehlbw <36572844+diehlbw@users.noreply.github.com>

…, improving docstrings

…ss_visual

src/seismometer/report/fairness.py

src/seismometer/controls/explore.py

src/seismometer/report/fairness.py

src/seismometer/data/performance.py

tests/data/test_performance.py

Co-authored-by: diehlbw <36572844+diehlbw@users.noreply.github.com>

src/seismometer/report/fairness.py

src/seismometer/data/performance.py

docs/user_guide/index.rst

…_evaluation which is no longer in use.

example-notebooks/binary-classifier/classifier_bin.ipynb

src/seismometer/report/fairness.py

example-notebooks/binary-classifier/dictionary.yml

src/seismometer/data/performance.py

changelog/77.feature.rst

fixing typos Co-authored-by: MahmoodEtedadi <106454604+MahmoodEtedadi@users.noreply.github.com>

src/seismometer/data/performance.py

add type hints Co-authored-by: MahmoodEtedadi <106454604+MahmoodEtedadi@users.noreply.github.com>

gbowlin added 11 commits October 7, 2024 19:35

initial table move

1b92ec2

add binary fairness control

67cf0f4

catch errors in plot code

c521e66

fix unit tests

2e20f1d

Remove Aequitas

afe3db5

remove fairness_audit documentation and stub, fix refresh on scores, …

dc827df

…remove update to config

add performance unit tests

a3a489b

fix sort order for cohort groups

4be7bba

more unit tests

f416678

add some fuz testing for fairness visual

71914f8

add icon tests

94db68c

gbowlin requested a review from diehlbw October 10, 2024 22:38

gbowlin commented Oct 10, 2024

View reviewed changes

src/seismometer/report/fairness.py Show resolved Hide resolved

diehlbw requested changes Oct 11, 2024

View reviewed changes

gbowlin marked this pull request as ready for review October 14, 2024 12:49

gbowlin requested a review from a team as a code owner October 14, 2024 12:49

gbowlin and others added 3 commits October 14, 2024 08:31

Apply suggestions from code review

f4fec2c

Co-authored-by: diehlbw <36572844+diehlbw@users.noreply.github.com>

remove audit extra - leave it as a default since its just great tables

c9f2a8b

reserve count, fix indentation in fairness.py

0946e42

gbowlin requested a review from diehlbw October 14, 2024 22:04

gbowlin changed the title ~~Draft: replace altair based fairness visual with great_tables visual~~ Replace altair based fairness visual with great_tables visual Oct 16, 2024

gbowlin and others added 5 commits October 16, 2024 19:16

Fixed the scaling issue to be consistent, can now allow larger scales…

4b36984

…, improving docstrings

doc fixes

403c774

fix casing

43cf742

Merge branch 'epic-open-source:main' into replace_altair_based_fairne…

a0f7b83

…ss_visual

Merge branch 'epic-open-source:main' into replace_altair_based_fairne…

d3b29f9

…ss_visual

diehlbw requested changes Oct 16, 2024

View reviewed changes

Apply suggestions from code review

73e43dd

Co-authored-by: diehlbw <36572844+diehlbw@users.noreply.github.com>

diehlbw reviewed Oct 17, 2024

View reviewed changes

src/seismometer/report/fairness.py Show resolved Hide resolved

src/seismometer/data/performance.py Outdated Show resolved Hide resolved

amunozdelrio reviewed Oct 17, 2024

View reviewed changes

docs/user_guide/index.rst Show resolved Hide resolved

gbowlin added 6 commits October 22, 2024 14:06

update test for new verbiage

fd2d447

Use new dataset from seismometer-data + remove sg.data and api.cohort…

440d579

…_evaluation which is no longer in use.

ignore config files, they will be pulled from seismometer-data now

5d1399e

data redirect by repo

dba2397

remove numba

6473b8e

remove try except, keep thresholds consistent

3ccb94f

gbowlin requested a review from diehlbw October 22, 2024 21:04

gbowlin mentioned this pull request Oct 22, 2024

Add additional scores and events to dataset epic-open-source/seismometer-data#4

Merged

fix sphinx

5b7c172

diehlbw requested changes Oct 23, 2024

View reviewed changes

example-notebooks/binary-classifier/classifier_bin.ipynb Show resolved Hide resolved

src/seismometer/report/fairness.py Outdated Show resolved Hide resolved

gbowlin mentioned this pull request Oct 23, 2024

Example notebooks should put data loading into a single function call. #105

Closed

repace isnan with isfinite to handle inf

c0973d5

gbowlin requested a review from diehlbw October 23, 2024 20:03

gbowlin added 3 commits October 23, 2024 20:30

remove negatation issue

ca5c4f7

fix branch/repo reference in notebook to the default repo/branch

37c01c7

return inf as potential output

9330b09

MahmoodEtedadi requested changes Oct 24, 2024

View reviewed changes

example-notebooks/binary-classifier/dictionary.yml Outdated Show resolved Hide resolved

src/seismometer/data/performance.py Outdated Show resolved Hide resolved

src/seismometer/data/performance.py Outdated Show resolved Hide resolved

changelog/77.feature.rst Outdated Show resolved Hide resolved

gbowlin and others added 2 commits October 24, 2024 18:05

Apply suggestions from code review - fix typos

d17bf7f

fixing typos Co-authored-by: MahmoodEtedadi <106454604+MahmoodEtedadi@users.noreply.github.com>

fix spellings

bcad03f

gbowlin requested a review from MahmoodEtedadi October 25, 2024 12:55

MahmoodEtedadi reviewed Oct 25, 2024

View reviewed changes

src/seismometer/data/performance.py Outdated Show resolved Hide resolved

Update src/seismometer/data/performance.py

376a7e2

add type hints Co-authored-by: MahmoodEtedadi <106454604+MahmoodEtedadi@users.noreply.github.com>

gbowlin requested a review from MahmoodEtedadi October 25, 2024 17:00

MahmoodEtedadi previously approved these changes Oct 25, 2024

View reviewed changes

fix linting issue

773623d

gbowlin dismissed MahmoodEtedadi’s stale review via 773623d October 25, 2024 17:41

MahmoodEtedadi self-requested a review October 25, 2024 17:50

MahmoodEtedadi approved these changes Oct 25, 2024

View reviewed changes

diehlbw approved these changes Oct 25, 2024

View reviewed changes

gbowlin merged commit 8ae4df1 into epic-open-source:main Oct 25, 2024
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace altair based fairness visual with great_tables visual #99

Replace altair based fairness visual with great_tables visual #99

gbowlin commented Oct 8, 2024

Replace altair based fairness visual with great_tables visual #99

Replace altair based fairness visual with great_tables visual #99

Conversation

gbowlin commented Oct 8, 2024

Overview

Description of changes

Author Checklist