Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of ps command #104

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Overhaul of ps command #104

merged 4 commits into from
Mar 8, 2024

Conversation

marcelldls
Copy link
Collaborator

This PR tries to do the following for ec ps:

  • Eliminates the charts that are shown which are not services - fixes ec ps -a showing "epics-pvcs"  #101
  • Return consistent information between local and k8s domains by adding restarts, running status, image information
  • Replaces pandas with polars. Improves pip install time from 50s to 20s and solves return alignment issues.

I had to change the podman/docker ps -o to be json rather than customised table as docker does not support getting the restart information - which had the benefit of removing the need for a regex for version information and makes it easier to get labels.

In order to get consistency with the status I decided to just have a bool for "running" since this differs between k8s and podman/docker

@gilesknap
Copy link
Member

This looks great. Many thanks. Merging.

@marcelldls marcelldls marked this pull request as ready for review March 5, 2024 09:59
@gilesknap
Copy link
Member

This looks great. Merging (this time I really mean it)

@gilesknap gilesknap merged commit 703a23d into main Mar 8, 2024
15 checks passed
@marcelldls marcelldls deleted the ps-enhance branch March 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec ps -a showing "epics-pvcs"
2 participants