Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap stop/start to use "temp" as default behavior #169

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

marcelldls
Copy link
Collaborator

e.g:
ec stop <ioc> --temp becomes ec stop <ioc>
ec stop <ioc> becomes ec stop <ioc> --commit
closes #167

@marcelldls marcelldls requested a review from gilesknap October 9, 2024 09:58
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (5a7b136) to head (fea97f4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/edge_containers_cli/cli.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files          16       16           
  Lines         968      968           
=======================================
  Hits          795      795           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gilesknap
Copy link
Member

This looks all good

@marcelldls marcelldls merged commit d12db4f into main Oct 14, 2024
17 checks passed
@marcelldls marcelldls deleted the swap-temp-argo branch October 14, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap start/stop to be argocd patches by default
2 participants