Realistic examples in system tests

[gilesknap]

No description provided.

[gilesknap]

@GDYendell you might be interested in this as it hopefully fixes an issue you raised with the ibek system tests.
But don't spend lots of time on it - the tests pass and the coverage is good (still need to add tests for the the subcommands that call shell - thats next).

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3818519) 70.62% compared to head (858582d) 70.51%.
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   70.62%   70.51%   -0.11%     
==========================================
  Files          17       17              
  Lines         926      926              
==========================================
- Hits          654      653       -1     
- Misses        272      273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gilesknap]

@coretl you might be interested to know I have added checks for jinja escaping. Does this cover what you asked me about recently?

ibek/tests/samples/iocs/ibek-mo-ioc-01.yaml

Lines 26 to 32 in 858582d

	- type: motorSim.simMotorAxis
	controller: controllerOne
	M: M{{ADDR}}
	ADDR: 1
	# verify escaping for jinja templating
	DESC: "Motor {{ADDR}} {% raw %} {{enclosed in escaped curly braces}} {% endraw %}"
	home: 500

ibek/tests/samples/support/asyn.ibek.support.yaml

Lines 110 to 121 in 858582d

	pre_init:
	- value: |
	# Setting up Asyn Port {{name}} on {{port}}:
	- when: first
	# test escaping of jinja directives and use of 'first' to only print this line once
	value: |
	# {% raw %}AsynIPConfigure({{name}}, {{port}}, {{stop}}, {{parity}}, {{bits}}) {% endraw %}
	- value: |
	AsynIPConfigure({{name}}, {{port}}, {{stop}}, {{parity}}, {{bits}})
	asynSetOption({{baud}}, 0, {{crtscts}}, {{disconnectOnReadTimeout}})
	asynOctetSetInputEos({{input_eos}})
	asynOctetSetOutputEos({{output_eos}})

ibek/tests/samples/support/motorSim.ibek.support.yaml

Lines 34 to 44 in 858582d

	- type: str
	name: DESC
	description: |-
	The description of the controller
	default: "Simulated Motion Controller testing escaping: {% raw %} {{enclosed in escaped curly braces}} {% endraw %}"
	pre_init:
	- value: |
	# motorSimCreateController(controller_asyn_port_name, axis_count)
	# testing escaping: {% raw %} {{enclosed in escaped curly braces}} {% endraw %}
	motorSimCreateController({{controllerName}}, {{numAxes}})

See the expected results in https://github.com/epics-containers/ibek/tree/dev/tests/samples/outputs

[GDYendell]

This could also be turned into a realistic example if you choose an appropriate PV to describe in the yaml

[gilesknap]

Good point. Will add that

[GDYendell]

This is great! Just one comment.