Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Skeleton Workflow Changes #27

Merged
merged 14 commits into from
May 31, 2022
Merged

Container Skeleton Workflow Changes #27

merged 14 commits into from
May 31, 2022

Conversation

gilesknap
Copy link
Member

@gilesknap gilesknap commented May 13, 2022

Preview of the changes that will go into skeleton for containerized python projects.

  • add devcontainer
  • add build and publish runtime container
  • switch to pip only from pipenv
  • use tox for command line lint tools etc.
  • use setupToolsSCM instead of versiongit

ibek is to be an early adopter of this since it does not require a release in the DLS RHEL7 infrastructure.

gilesknap added 6 commits May 12, 2022 12:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #27 (b8f0e5c) into main (5a8d40b) will decrease coverage by 0.58%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   98.44%   97.86%   -0.59%     
==========================================
  Files           8        8              
  Lines         322      328       +6     
==========================================
+ Hits          317      321       +4     
- Misses          5        7       +2     
Impacted Files Coverage Δ
src/ibek/__init__.py 75.00% <71.42%> (-25.00%) ⬇️
src/ibek/ioc.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@gilesknap gilesknap requested a review from coretl May 13, 2022 13:48
@gilesknap
Copy link
Member Author

@coretl I think this is done now - the new "install with locked/latest dependencies" looks much nicer

@gilesknap
Copy link
Member Author

gilesknap commented May 13, 2022

I had to give up on generic ENTRYPOINT - it is only sort of possible through nasty hacks - removing it simplifies the code.yml anyway. https://stackoverflow.com/questions/34324277/how-to-pass-arg-value-to-entrypoint

@gilesknap
Copy link
Member Author

@coretl I'm planning to go ahead and merge this if you agree. This is one project that does not really need to be released in the traditional DLS way, right?

@gilesknap gilesknap merged commit d93d29c into main May 31, 2022
@gilesknap gilesknap deleted the skeleton2 branch May 31, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants