Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Entity.__dict__ instead of __context__ #69

Merged
merged 2 commits into from
May 15, 2023
Merged

switch to Entity.__dict__ instead of __context__ #69

merged 2 commits into from
May 15, 2023

Conversation

gilesknap
Copy link
Member

Tidy up the approach of passing Entity attributes to Jinja context. Including how 'values' fields are added.

All values for the jinja context are now just ordinary attributes on Entity and area passed using dict.

@gilesknap gilesknap temporarily deployed to github-pages May 12, 2023 06:25 — with GitHub Actions Inactive
@gilesknap
Copy link
Member Author

@coretl I think I'm happy with this now. Take a look if you wish.

@gilesknap gilesknap temporarily deployed to github-pages May 12, 2023 07:53 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #69 (5880bfe) into main (6751512) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   97.40%   97.38%   -0.03%     
==========================================
  Files           9        9              
  Lines         386      382       -4     
==========================================
- Hits          376      372       -4     
  Misses         10       10              
Impacted Files Coverage Δ
src/ibek/ioc.py 97.75% <100.00%> (-0.08%) ⬇️
src/ibek/render.py 96.47% <100.00%> (-0.09%) ⬇️
src/ibek/utils.py 90.90% <100.00%> (+0.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gilesknap gilesknap merged commit 0424ee8 into main May 15, 2023
@gilesknap gilesknap deleted the values branch November 11, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants