-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace APISchema with Pydantic2 #85
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 97.73% 97.24% -0.49%
==========================================
Files 9 9
Lines 397 363 -34
==========================================
- Hits 388 353 -35
- Misses 9 10 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@coretl I'm really happy with this. It came out beautiful after all. The schemas look very different but the sample docs in the tests are unchanged. Only caveat is that the docs are broken and I can't work out how to fix them. I'd appreciate you taking a look over the changes and maybe fixing the docs if you can. NOTE: the commit history is a mess and I'm intending to squash merge this. |
Fun fact. render_with_utils was written by CoPilot, including the comments. |
@coretl sphinx is fixed and I have added a TODO to Entity.add_ibek_attributes regarding the issue with error messages for object type entities. |
No description provided.