Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update genicam template names and cope with missing camera with auto-gen #45

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

gilesknap
Copy link
Member

@gilesknap gilesknap commented Nov 12, 2024

Some minor improvements to make genicam more robust:

  • for auto-gen Class of camera, make the pvi device ID 'auto-' with camera ID as the suffix
    • because the old approach created illegal device names when ID was ip address
  • cope with arv-tool failing to connect to the camera in start.sh
  • update the 'CLASS' enum in ADAravis.ibek.support.yaml to match the set of templates in the most recent ADGenicam
    • and update the pvi entry to match the new ID scheme above

@gilesknap gilesknap requested a review from marcelldls November 12, 2024 13:43
@gilesknap
Copy link
Member Author

@marcelldls I have also cheesed handling of the problem that CI fails with aravias autogen pvi-device.

It's a pretty benign cheese:
https://github.com/epics-containers/p47-services/blob/d01eef12b3c34b3f7fc79dec56503254ec94bce3/.github/workflows/ci_verify.sh#L64-L65

Copy link
Contributor

@marcelldls marcelldls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGMT. Are we happy with the silent fail?

@gilesknap
Copy link
Member Author

Weeeeeeell I'd like to say

echo can't connect to camera
exit 1

But for those that choose the path of >1 camera per IOC this would be bad.

So shall we pop in a

echo can't connect to camera ${instance_id}

@marcelldls
Copy link
Contributor

Weeeeeeell I'd like to say

echo can't connect to camera
exit 1

But for those that choose the path of >1 camera per IOC this would be bad.

So shall we pop in a

echo can't connect to camera ${instance_id}

Thats a fair compromise

@marcelldls marcelldls merged commit f73bfe7 into main Nov 14, 2024
3 checks passed
@marcelldls marcelldls deleted the fix-auto-settings branch November 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants