Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to convert templates to Device without header #125

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

GDYendell
Copy link
Member

@GDYendell GDYendell commented Jul 10, 2024

This is a breaking change to the convert device CLI.

Change header from required positional arg to option --header.
Add --name and --parent args to specificy without header.
Add --label to override UI label of Device.

Fixes #120

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.78%. Comparing base (a8e884c) to head (013be18).

Files Patch % Lines
src/pvi/__main__.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files          23       23           
  Lines        1449     1459   +10     
=======================================
+ Hits         1301     1310    +9     
- Misses        148      149    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is a breaking change to the convert device CLI.

Change header from required positional arg to option --header.
Add --name and --parent args to specificy without header.
Add --label to override UI label of Device.
@GDYendell GDYendell merged commit 9648c5b into main Aug 9, 2024
17 of 18 checks passed
@GDYendell GDYendell deleted the convert-template branch August 9, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow not passing a header file to create a device yaml with only a template
1 participant