Implement DeviceRef #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@GDYendell is there a reason this is not merged? |
|
Just that it hadn't been tested for what it was added for. I assume now it needs updating to use pydantic? |
GDYendell
force-pushed
the
device-ref
branch
2 times, most recently
from
42b1f18 to
6a51e67
Compare
GDYendell
force-pushed
the
device-ref
branch
2 times, most recently
from
eb258bc to
50de151
Compare
GDYendell
force-pushed
the
device-ref
branch
2 times, most recently
from
190b27b to
d25e747
Compare
Add `ui` field to format a button to open the referenced display.
Add warning when row components are ignored Move is_table to screen as it is the only place it is used
Rename bob template fields to distinguish between OpenDisplay and WritePV buttons Use name for description on action buttons
Previously when converting read records without an `_RBV` suffix it would be wrongly appended anyway. Add dummy read record to sim detector input to verify this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.