Fix SignalRW read_pv convert #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion was defaulting to use name + RBV for read_pv, which is now not correct. This fix makes SettingPair pass in the read_record so that the pv comes from the template. It would probably be possible to refactor these classes so that more fields are required and checks for None can be removed.
|
@gilesknap apologies you may need to check the convert you did for motor with this latest version. If you had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion was defaulting to use
name+ _RBV forread_pv, which is now not correct.This fix makes
SettingPairpass in theread_recordso that the pv comes from the template.It would probably be possible to refactor these classes so that more fields are required and checks for
Nonecan be removed.