PVI #117
Merged
PVI #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably don't want to add the .dls-build-master file to the official distribution. |
|
This PR has a conflict. I believe this is coming because you removed trailing whitespace before issuing the PR, but subsequently I have removed trailing whitespace in all files on the master branch. This also makes it very difficult to see just what files you really changed. Can you merge master into the dls-controls:pvi branch so these conflicts and apparent changes go away? |
Add asynPortDriver::createParams method to iterate asynParamSet paramDefinitions and call createParam on any entries.
|
Thanks for making the whitespace changes, that makes things easier. The diff should be clearer now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates new asynParam and asynParamSet classes to store the parameter definitions separately from the driver class and updates asynPortDriver to have an asynParamSet and call createParam on all the parameters stored within it from child classes. There is a new asynPortDriver constructor that takes a asynParamSet and calls createParams.
For full context see: areaDetector/ADCore#446