Fix issue with power being left on when using auto power control in asynMotorController. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we have auto power on enabled but there is no actual move.
…want to power off if we detect externally generated moves.
|
Looks good to me |
rerpha
pushed a commit
to rerpha/motor
that referenced
this pull request
Nov 21, 2022
…0_Send_McLennan_reset_on_move Send the reset command after every move. Configurable at startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a problem when telling the motor to move to the position it's already at. If the move command made to it to the driver, the amplifier was powered on, but we never detect an end of move, so the amplifier was left on.