avoid error storms with disconnected controllers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had an issue with multi-gigabyte soft IOC log files where we actually ran out of disk space. The phytronMotor module was identified as one of the chief culprits, so I wanted to see if this could be fixed. The patch is quite repetitive; it makes the same change for most uses of asynPrint in the code. This is ugly and normally the first thing I would do is to extract this functionality into a separate procedure or method. But asynPrint uses varargs and is defined in asyn as a macro with complicated #ifdefs depending on OS and compiler. This made me think it may not be easily possible to factor this out in a portable manner.
The other two patches are simple and obvious cleanups.