Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#806 - page jump caused by h-screen on wrapping div #886

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

rajeshg
Copy link
Contributor

@rajeshg rajeshg commented Nov 20, 2024

Fixes issue #806

h-screen limits the height of the wrapping div to screen size. Changing to min-h-screen applies a minimum height as should be the case for a wrapping div like this.

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

Before:
image

After:
image

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 6684435 into epicweb-dev:main Nov 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants