-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playlists and stuff #55
Open
NecroKote
wants to merge
24
commits into
epidemicsound:main
Choose a base branch
from
NecroKote:playlists
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also contains minor improvements and is 100% test-free !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
This is a Pull Request adds Playlist functionality for this service.
It allows users to:
Some other "questional improvements" were made as well:
API_HOST
controls the address of the backendNotes around changes
I started my journey by trying to thing about the best way to implement the "reorder" playlist functionality as basic CRUD seemed trivial.
After a while I came to a conclusion that using Double Linked List would be the best way to implement this. The solution is not without it's flaws however:
services.playlise.get_playlist_tracks
)There are however some obvious benefits:
After patting myself on the back for the "smartass" solution for track ordering I tooke this part of the readme: "If you want to add extra features or explore something you’re passionate about, we encourage you to do so..." too seriously and went a bit overboard with the UI changes.
Shrapnel-style commits and no clear plan of action was my way of doing things :D
I added the drag-and-drop functionality to the playlist, added the ability to play the tracks from the playlist, added the ability to switch tracks back and forth while listening to the playlist.
The idea was to "show off" as much as possible and use 0 external libraries. While my solution is far away from being perfect, I am quite happy with the result.
I learned a lot about quirks of the React in the process. Time well spenk.