Merge pull request #40 from episerver/bugfix/MAR-1671-ABTesting-data-…

…is-counted-incorrectly Fix ProxyEventHandler added multiple time
episerver · Jul 31, 2023 · d340892 · d340892
2 parents 92c02c0 + 4e221f0
commit d340892
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/EPiServer.Marketing.Testing.Web/Helpers/IReferenceCounter.cs b/src/EPiServer.Marketing.Testing.Web/Helpers/IReferenceCounter.cs
@@ -8,5 +8,6 @@ public interface IReferenceCounter
         void RemoveReference(object src);
         Boolean hasReference(object src);
         int getReferenceCount(object src);
+        bool IsNullOrEmpty();
     }
 }
diff --git a/src/EPiServer.Marketing.Testing.Web/Helpers/ReferenceCounter.cs b/src/EPiServer.Marketing.Testing.Web/Helpers/ReferenceCounter.cs
@@ -51,5 +51,9 @@ public int getReferenceCount(object src)
             dictionary.TryGetValue(src, out value);
             return value;                
         }
+
+        public bool IsNullOrEmpty() { 
+            return dictionary is null || (dictionary.Count == 0); 
+        }
     }
 }
diff --git a/src/EPiServer.Marketing.Testing.Web/TestHandler/TestHandler.cs b/src/EPiServer.Marketing.Testing.Web/TestHandler/TestHandler.cs
@@ -667,7 +667,7 @@ internal void AddProxyEventHandler(IKpi kpi)
 
             // Add the proxyeventhandler only once, if its in our reference counter, just increment
             // the reference.
-            if (!_ReferenceCounter.hasReference(kpi.GetType()))
+            if (_ReferenceCounter.IsNullOrEmpty())
             {
                 kpi.EvaluateProxyEvent += ProxyEventHandler;
                 _ReferenceCounter.AddReference(kpi.GetType());
@@ -689,7 +689,7 @@ internal void RemoveProxyEventHandler(IKpi kpi)
             _ReferenceCounter.RemoveReference(kpi.GetType());
 
             // Remove the proxyeventhandler only once, when the last reference is removed.
-            if (!_ReferenceCounter.hasReference(kpi.GetType()))
+            if (_ReferenceCounter.IsNullOrEmpty())
             {
                 kpi.EvaluateProxyEvent -= ProxyEventHandler;
             }