Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AFORM-4451: error when going to back next step on depend form #161

Merged
merged 1 commit into from
Oct 29, 2024
Merged

AFORM-4451: error when going to back next step on depend form #161

merged 1 commit into from
Oct 29, 2024

Conversation

thachnd
Copy link
Contributor

@thachnd thachnd commented Oct 28, 2024

@thachnd thachnd requested a review from a team as a code owner October 28, 2024 04:17
@quantranepiserver
Copy link
Contributor

actualValue can be null or undefined, we should check null first
actualValue?.toString()

@quantranepiserver
Copy link
Contributor

Why we merge into release branch ?

@thachnd
Copy link
Contributor Author

thachnd commented Oct 29, 2024

actualValue can be null or undefined, we should check null first actualValue?.toString()

the statement !actualValue ? "" : getConcatString(actualValue.toString(), ",").toLocaleUpperCase(); already checked

@thachnd
Copy link
Contributor Author

thachnd commented Oct 29, 2024

Why we merge into release branch ?

This bug from testing the current release

@thachnd thachnd merged commit 880c3a6 into release/1.0.1 Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantranepiserver quantranepiserver quantranepiserver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thachnd @quantranepiserver