Add license expression to package #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennys
requested review from
shahramshahram,
JohanPetersson,
jbearfoot,
pergunsarfs,
jotiepiserver and
tidyui
as code owners
JohanPetersson
approved these changes
Mar 16, 2022
JohanPetersson
added a commit
that referenced
this pull request
Mar 24, 2022
* Adds order managers mapped role * Add content type item template (#17) * Add Content Type item template * Update README with additional details (#19) Also fix parameter spelling error * Add scheduled job item template (#20) * Add Initialization Module item template (#18) * Add Initialization Module item template * correct parameter name * Add Page Controller template (#23) * Add Content Component template (#24) * Razor page item template (#25) * Add Razor Page Item template * Fix some copy/paste naming errors * List all item templates (#26) * Publish CI packages to GitHub Packages (#27) * Publish CI packages to GitHub Packages * Supress .NET welcome msg during builds * Add license expression to package (#28) * Updates CMS to latest (#30) * Various bugfixes (#31) * Fixes broken link in content * Makes section handling more resilient Now handles created below root directly. * Increases timeout for database creation * Updates the version * Reverts to 1.1 since this will be next release (#32) * Delete old package versions (#29) * Delete old package versions. Keep 10 versions * Split cleanup into separate step * Fixes inconsistent file naming on disk and code files (#35) The template engine replaces whitespace with - in filenames and _ in text files. That means db filenames on disk doesn't match the names in the connection strings. We need to use unambiguous source names, so unfortunately we end up with ugly project names and namespaces. But this ensures everything gets replaced correctly, see https://github.com/dotnet/templating/wiki/Naming-and-default-value-forms. Added restart on failure in Docker compose. Services are just started in correct order, but do not wait until they are ready. The db might take time to set up first time on a slow machine, then the web fails and you have to 'docker up' again. There is no nice way to achieve this in another way, other than making the app itself more resilient. Also updated with our v3 NuGet feed. Co-authored-by: Henrik Nystrom <henrik.nystrom@gmail.com> Co-authored-by: Henrik Nystrom <henrik.nystrom@episerver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.