Improve Multi-Instance Docker Support and DB Restoration Fix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add a .env file to each Docker project that specifies a DB_DIRECTORY. This environment variable will specify a new directory on /var/opt/mssql/host_data/ within the container so that the DB may persist when adding other docker projects of type mssql/server:2019-latest.
If the container and its network are deleted, then the databases will be dropped. So when `docker compose up` runs again to create the containers, then the `CREATE DATABASE` command won't work since there is already a .mdf/.ldf file existent. This is why the `FOR ATTACH` command is needed in this case if the files already exist.
gabepetersen
requested review from
hennys,
shahramshahram,
JohanPetersson,
jbearfoot,
pergunsarfs and
tidyui
as code owners
gabepetersen
added a commit
to gabepetersen/OptiGraphExperiment
that referenced
this pull request
Oct 25, 2023
Based on my PR here: episerver/content-templates#47
|
Thank you for this contribution. Before we can merge this, we need make this work a bit better with the templating system;
|
Fix in response to episerver#47 (comment). See https://learn.microsoft.com/en-us/dotnet/core/tools/custom-templates for information on custom templates.
|
@JohanPetersson I apologize for my late response to this. The recent commit 182b656 should update the code according to your recent comment. For the empty commerce template |
JohanPetersson
requested changes
Nov 7, 2023
This will also fix the DB directory for the empty commerce template to be the variable of the project name
gabepetersen
force-pushed
the
fix-multiple-docker-instances
branch
from
5d0b43e
to
4a9d57c
Compare
|
@JohanPetersson Sorry again for the late response, I was out on vacation. Fixes to the recent change requests are in 4a9d57c. Since I accidentally removed the newlines from the |
JohanPetersson
previously approved these changes
Nov 13, 2023
JohanPetersson
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will accomplish two tasks:
The ability for multiple Optimizely Docker projects to be created without storage conflicts in /var/opt/mssql/host_data
The ability to restore pre-existing databases from .mdf & .ldf files on
docker compose updocker compose upruns again to create the containers, then the plainCREATE DATABASEcommand won't work since there is already a .mdf & .ldf file copied over. This commit 3ca4fc2 will check if the .mdf file exists. If so, it will add aFOR ATTACHcommand to the end ofCREATE DATABASEto restore the DB from .mdf and .ldf.