Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Update gemspec file to latest style standards #21

Merged
merged 7 commits into from
Jan 16, 2020
Merged

Conversation

epistrephein
Copy link
Owner

@epistrephein epistrephein commented Jan 11, 2020

Pull Request description

  • Remove test_files attribute since it's deprecated and no longer used.
  • Use Dir[] instead of git ls-files to specify gem files, in order to improve readability and exclude unnecessary files.
  • Don't include development files and RSpec tests in the built gem.

Pull Request checklist

Kind of change
  • My code is a minor change (typo, configuration, anything not related to core functionality)
  • My code is a bug fix (non-breaking change which fixes an issue)
  • My code is a new feature (non-breaking change which adds functionality)
  • My code introduces a breaking change (fix or feature that would break existing functionality)
Style and tests
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
Documentation
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
Changelog
  • I have included the CHANGELOG entry for the changes

@epistrephein epistrephein self-assigned this Jan 11, 2020
@epistrephein epistrephein added the enhancement Improvements on existing functionality label Jan 11, 2020
@epistrephein epistrephein added this to the v2.0 milestone Jan 11, 2020
@epistrephein epistrephein merged commit 9f73f2c into master Jan 16, 2020
@epistrephein epistrephein deleted the gemspec-update branch January 16, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvements on existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant