Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add follow-up to data licensing post #360

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Conversation

joshwlambert
Copy link
Member

@joshwlambert joshwlambert commented Jan 15, 2025

This PR adds a follow-up post to the Dual licensing R packages with code and data blog post authored by @chartgerink and myself.

This post provides a short summary of the original post and then provides an update to the Licensing code and data in one R package section including our experience since writing the blog post developing {epiparameter} and getting it hosted on CRAN.

I've added a callout to the the first version of the blog post in the Licensing code and data in one R package section to direct readers to updated blog post.

This PR provides an alternative option to PR #359. The preferred option can be merged and the other PR can be closed without merging.

  • The post specifies a license if you don't want to use the default CC BY
  • All authors have an ORCID iD
  • Relevant keywords / tags has been added. In particular, if you want your post to be shared on R-bloggers, you must tag it with R
  • Images or other external resources have been committed and pushed
  • The post uses pure quarto syntax, rather than HTML or R code, unless necessary

Right before merging:

  • The date field has been updated
  • All reviewers have been acknowledged in a short paragraph
  • A PR has been opened in the blueprints to link to this post
  • The post has been re-rendered and content of the _freeze/ folder is up-to-date

/schedule 2025-01-27T08:00

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for tourmaline-marshmallow-241b40 ready!

Name Link
🔨 Latest commit daf994b
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/678fd0d7e13070000701286b
😎 Deploy Preview https://deploy-preview-360--tourmaline-marshmallow-241b40.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshwlambert
Copy link
Member Author

@chartgerink once you've had time to review and compare both options please let me know what you prefer and feel free to suggest changes.

Copy link
Member

@chartgerink chartgerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. It makes more sense to me this way, as the chronology is clearer and there is less reading between the lines necessary.

I left a few suggestions, and my only question is whether I should even be an author on this, because you did virtually all of the work!

posts/data-licensing.qmd Outdated Show resolved Hide resolved
posts/data-licensing-cran.qmd Outdated Show resolved Hide resolved
posts/data-licensing-cran.qmd Outdated Show resolved Hide resolved
joshwlambert and others added 3 commits January 21, 2025 16:50
Co-authored-by: Chris Hartgerink <chris@libscie.org>
Co-authored-by: Chris Hartgerink <chris@libscie.org>
Co-authored-by: Chris Hartgerink <chris@libscie.org>
@joshwlambert
Copy link
Member Author

joshwlambert commented Jan 21, 2025

Thanks for the suggestions @chartgerink. Given your involvement in discussing and formulating the structure of the post and what to include, your contribution was still substantial and warrants authorship in my opinion.

I'm happy for this to be merged.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Merge Schedule
Scheduled on 2025-01-27T08:00 (UTC) successfully merged

@github-actions github-actions bot merged commit 52fb412 into main Jan 27, 2025
10 checks passed
@github-actions github-actions bot deleted the license-post-learnings branch January 27, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants