Skip to content

Commit

Permalink
Closes #114, #80; Removed isVisible.
Browse files Browse the repository at this point in the history
Removed the method from the base class and all references from the source. Since we are no longer using the hack due to problems with the approach, we can close the performance test ticket (#80).
  • Loading branch information
rsandor committed Jul 9, 2014
1 parent 3013196 commit 787509c
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 12 deletions.
7 changes: 0 additions & 7 deletions src/core/chart.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ class Epoch.Chart.Base extends Epoch.Events
@width = defaults.width unless @width?
@height = defaults.height unless @height?

# Determines if the chart is currently visible in a document.
# @return [Boolean] True if the chart is visible, false otherwise.
isVisible: ->
return true
#return false unless @el?
#@el.is('*:visible')

# Set the initial data for the chart.
# @param data Data to initially set for the given chart. The data format can vary
# from chart to chart. The base class assumes that the data provided will be an
Expand Down
1 change: 0 additions & 1 deletion src/time/area.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ class Epoch.Time.Area extends Epoch.Time.Stack

# Draws the area chart.
draw: (delta=0) ->
return unless @isVisible()
@clear()
@_drawAreas(delta)
@_drawStrokes(delta)
Expand Down
1 change: 0 additions & 1 deletion src/time/bar.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class Epoch.Time.Bar extends Epoch.Time.Stack

# Draws the stacked bar chart.
draw: (delta=0) ->
return unless @isVisible()
@clear()
[y, w] = [@y(), @w()]

Expand Down
2 changes: 0 additions & 2 deletions src/time/gauge.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ class Epoch.Time.Gauge extends Epoch.Chart.Canvas

# Draws the gauge.
draw: ->
return unless @isVisible()

[cx, cy, r] = [@centerX(), @centerY(), @radius()]
[tickOffset, tickSize] = [@options.tickOffset, @options.tickSize]

Expand Down
1 change: 0 additions & 1 deletion src/time/heatmap.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ class Epoch.Time.Heatmap extends Epoch.Time.Plot

# Copies the paint canvas onto the display canvas, thus rendering the heatmap.
draw: (delta=0) ->
return unless @isVisible()
@clear()
@ctx.drawImage @paint, delta, 0
super()
Expand Down

0 comments on commit 787509c

Please sign in to comment.