Closes #62; Removed Dependance on jQuery #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completely removed jQuery as a dependancy of Epoch by creating a mini querying system for the library. Basically I hunted down all the ways that jQuery was being used and ensured that we mirrored the functionality using regular JavaScript. The new querying system, named `Epoch.Query` is where most of the heavy lifting takes place. In places where mirroring functionality seemed out of scope, or could be easily achieved with a simple call or two, I opted not to mirror functionality. One example is that of generating elements directly from html strings. This change touches quite a few places in the library and fundamentally changes the way we handle DOM querying and manipulation. As such, it would be prudent to get a few eyes on these changes before merging it into master.
rsandor
added a commit
that referenced
this pull request
Jun 29, 2014
Closes #62; Removed Dependance on jQuery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removed jQuery as a dependancy of Epoch by using d3's selections and implementing the missing jQuery features Epoch relied on.