Merge branch 'develop' for release v3.61.0

epoupon · Nov 30, 2024 · 864125c · 864125c
2 parents 8bbee8a + 435e8b2
commit 864125c
Show file tree

Hide file tree

Showing 102 changed files with 1,621 additions and 753 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -2,7 +2,6 @@
 Checks:          '-*,bugprone-*,concurrency-*,cppcoreguidelines-*,misc-*,-misc-include-cleaner,-misc-no-recursion,performance*,portability-*,readability-*,-readability-braces-around-statements,-readability-identifier-length,-readability-implicit-bool-conversion'
 WarningsAsErrors: ''
 HeaderFilterRegex: ''
-AnalyzeTemporaryDtors: false
 FormatStyle:     none
 User:            ''
 CheckOptions:

diff --git a/Dockerfile-release b/Dockerfile-release
@@ -2,7 +2,7 @@ FROM	alpine:3.19 AS build
 
 WORKDIR	/tmp/workdir
 
-ARG	PREFIX="/tmp/install"
+ENV	PREFIX="/tmp/install"
 
 ARG	BUILD_PACKAGES=" \
 	ca-certificates \
@@ -118,7 +118,7 @@ COPY . /tmp/lms/
 RUN \
 	DIR=/tmp/lms/build && mkdir -p ${DIR} && cd ${DIR} && \
 	PKG_CONFIG_PATH=/tmp/install/lib/pkgconfig CXXFLAGS="-I${PREFIX}/include" LDFLAGS="-L${PREFIX}/lib -Wl,--rpath-link=${PREFIX}/lib" cmake /tmp/lms/ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=${PREFIX} -DCMAKE_PREFIX_PATH=${PREFIX} && \
-	LD_LIBRARY_PATH=${PREFIX}/lib VERBOSE=1 make -j$(nproc) && \
+	LD_LIBRARY_PATH=${PREFIX}/lib make -j$(nproc) && \
 	LD_LIBRARY_PATH=${PREFIX}/lib make test && \
 	make install && \
 	mkdir -p ${PREFIX}/etc/ && \

diff --git a/SUBSONIC.md b/SUBSONIC.md
@@ -1,16 +1,24 @@
 # Subsonic API
-The API version implemented is 1.16.0 and has been tested on _Android_ using _Subsonic Player_, _Ultrasonic_, _Symfonium_, and _DSub_.
+The API version implemented is 1.16.0 and has been tested on _Android_ using _DSub_, _Subsonic Player_, _Symfonium_, _Tempo_ and  _Ultrasonic_.
 
 Folder navigation commands are supported. However, since _LMS_ does not store information for each folder, it is not possible to star/unstar folders considered as artists.
 Given the API limitations of folder navigation commands, it is recommended to place all tracks of an album in the same folder and not to mix multiple albums in the same folder.
 
 The Subsonic API is enabled by default.
 
-__Note__: since _LMS_ may store hashed and salted passwords or may forward authentication requests to external services, it cannot handle the __token authentication__ method. You may need to check your client to make sure to use the __password__ authentication method. Since logins/passwords are passed in plain text through URLs, it is highly recommended to use a unique password when using the Subsonic API. Note that this may affect the use of authentication via PAM. In any case, ensure the web server logs (and proxy logs, if applicable) are properly secured.
-
 # OpenSubsonic API
 OpenSubsonic is an initiative to patch and extend the legacy Subsonic API. You'll find more details in the [official documentation](https://opensubsonic.netlify.app/)
 
+## Authentication
+_LMS_ supports the [API Key Authentication](https://opensubsonic.netlify.app/docs/extensions/apikeyauth/) method. Each user has to generate their own API key on the settings page to use the Subsonic API.
+
+By default, API keys can also be used as passwords, provided the `user` parameter matches the API key owner. To disable this fallback authentication method, set the following in `lms.conf`:
+```
+api-subsonic-support-user-password-auth = false;
+```
+
+__Note__: the token+salt authentication method is not supported.
+
 ## Extra fields
 The following extra fields are implemented:
 * `Album` response:
@@ -50,5 +58,7 @@ The following extra fields are implemented:
   * `roles`
 
 ## Supported extensions
+* [API Key Authentication](https://opensubsonic.netlify.app/docs/extensions/apikeyauth/)
+* [HTTP form POST](https://opensubsonic.netlify.app/docs/extensions/formpost/)
 * [Transcode offset](https://opensubsonic.netlify.app/docs/extensions/transcodeoffset/)
 * [Song Lyrics](https://opensubsonic.netlify.app/docs/extensions/songlyrics/)
diff --git a/approot/messages.xml b/approot/messages.xml
@@ -289,7 +289,7 @@
 <!--Settings-->
 <message id="Lms.Settings.artist-release-sort-method">Method to sort artist's albums</message>
 <message id="Lms.Settings.audio">Audio</message>
-<message id="Lms.Settings.audio-settings-are-local">These audio settings are local to your browser!</message>
+<message id="Lms.Settings.audio-settings-are-local">These audio settings are local to your browser</message>
 <message id="Lms.Settings.backend.internal">Internal</message>
 <message id="Lms.Settings.backend.listenbrainz">ListenBrainz</message>
 <message id="Lms.Settings.backend.listenbrainz-token">ListenBrainz API token</message>
@@ -307,6 +307,7 @@
 <message id="Lms.Settings.original-date-desc">Original Release Date (Descending)</message>
 <message id="Lms.Settings.password-bad">Bad password</message>
 <message id="Lms.Settings.password-must-fill-old-password">Old password must be filled in</message>
+<message id="Lms.Settings.regen-token">Generate</message>
 <message id="Lms.Settings.replaygain-mode">ReplayGain mode</message>
 <message id="Lms.Settings.replaygain-mode.none">No ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.auto">Auto</message>
@@ -317,24 +318,26 @@
 <message id="Lms.Settings.scrobbling">Scrobbling</message>
 <message id="Lms.Settings.services">Services</message>
 <message id="Lms.Settings.settings">Settings</message>
+<message id="Lms.Settings.settings-saved">New settings saved!</message>
 <message id="Lms.Settings.subsonic-artist-list-mode">Artist list mode</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">All artists</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.release-artists">Album artists</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.track-artists">Track artists</message>
 <message id="Lms.Settings.subsonic-api">Subsonic API</message>
-<message id="Lms.Settings.user-interface">User Interface</message>
+<message id="Lms.Settings.subsonic-token">OpenSubsonic API key</message>
+<message id="Lms.Settings.subsonic-token-usage">Use this API key as the password for clients that do not support the 'API Key Authentication' extension</message>
 <message id="Lms.Settings.transcoding">Transcoding</message>
+<message id="Lms.Settings.transcoding-mode">Enable transcoding</message>
+<message id="Lms.Settings.transcoding-mode.always">Always</message>
+<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Only when format is not supported by the browser</message>
+<message id="Lms.Settings.transcoding-mode.never">Never</message>
 <message id="Lms.Settings.transcoding-output-bitrate">Transcoding output bitrate</message>
 <message id="Lms.Settings.transcoding-output-format">Transcoding output format</message>
 <message id="Lms.Settings.transcoding-output-format.matroska_opus">Matroska/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.mp3">MP3</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_opus">Ogg/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_vorbis">Ogg/Vorbis</message>
 <message id="Lms.Settings.transcoding-output-format.webm_vorbis">WebM/Vorbis</message>
-<message id="Lms.Settings.transcoding-mode">Enable transcoding</message>
-<message id="Lms.Settings.transcoding-mode.always">Always</message>
-<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Only when format is not supported by the browser</message>
-<message id="Lms.Settings.transcoding-mode.never">Never</message>
-<message id="Lms.Settings.settings-saved">New settings saved!</message>
+<message id="Lms.Settings.user-interface">User Interface</message>
 
 </messages>
diff --git a/approot/messages_fr.xml b/approot/messages_fr.xml
@@ -289,7 +289,7 @@
 <!--Settings-->
 <message id="Lms.Settings.artist-release-sort-method">Méthode pour trier les albums de l'artiste</message>
 <message id="Lms.Settings.audio">Audio</message>
-<message id="Lms.Settings.audio-settings-are-local">Ces paramètres audio sont locaux à votre navigateur !</message>
+<message id="Lms.Settings.audio-settings-are-local">Ces paramètres audio sont locaux à votre navigateur</message>
 <message id="Lms.Settings.backend.internal">Interne</message>
 <message id="Lms.Settings.backend.listenbrainz">ListenBrainz</message>
 <message id="Lms.Settings.backend.listenbrainz-token">Jeton d'API ListenBrainz</message>
@@ -307,6 +307,7 @@
 <message id="Lms.Settings.original-date-desc">Date de sortie originale (Décroissant)</message>
 <message id="Lms.Settings.password-bad">Mauvais mot de passe</message>
 <message id="Lms.Settings.password-must-fill-old-password">L'ancien mot de passe doit être renseigné</message>
+<message id="Lms.Settings.regen-token">Regénérer</message>
 <message id="Lms.Settings.replaygain-mode">Mode ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.none">Pas de ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.auto">Automatique</message>
@@ -317,25 +318,27 @@
 <message id="Lms.Settings.scrobbling">Scrobbling</message>
 <message id="Lms.Settings.services">Services</message>
 <message id="Lms.Settings.settings">Paramètres</message>
+<message id="Lms.Settings.settings-saved">Paramètres sauvegardés !</message>
 <message id="Lms.Settings.subsonic-artist-list-mode">Mode de listage des artistes</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">Tous les artistes</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.release-artists">Tous les artistes d'album</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.track-artists">Tous les artistes de piste</message>
 <message id="Lms.Settings.subsonic-api">API Subsonic</message>
-<message id="Lms.Settings.user-interface">Interface utilisateur</message>
+<message id="Lms.Settings.subsonic-token">Clef pour l'API OpenSubsonic</message>
+<message id="Lms.Settings.subsonic-token-usage">Utilisez cette clé d'API comme mot de passe pour les clients qui ne prennent pas en charge l'extension 'API Key Authentication'</message>
 <message id="Lms.Settings.transcoding">Transcodage</message>
+<message id="Lms.Settings.transcoding-mode">Appliquer le transcodage</message>
+<message id="Lms.Settings.transcoding-mode.always">Toujours</message>
+<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Seulement lorsque le format n'est pas pris en charge par votre navigateur</message>
+<message id="Lms.Settings.transcoding-mode.never">Jamais</message>
 <message id="Lms.Settings.transcoding-output-bitrate">Bitrate du transcodage</message>
 <message id="Lms.Settings.transcoding-output-format">Format du transcodage</message>
 <message id="Lms.Settings.transcoding-output-format.matroska_opus">Matroska/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.mp3">MP3</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_opus">Ogg/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_vorbis">Ogg/Vorbis</message>
 <message id="Lms.Settings.transcoding-output-format.webm_vorbis">WebM/Vorbis</message>
-<message id="Lms.Settings.transcoding-mode">Appliquer le transcodage</message>
-<message id="Lms.Settings.transcoding-mode.always">Toujours</message>
-<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Seulement lorsque le format n'est pas pris en charge par votre navigateur</message>
-<message id="Lms.Settings.transcoding-mode.never">Jamais</message>
-<message id="Lms.Settings.settings-saved">Paramètres sauvegardés !</message>
+<message id="Lms.Settings.user-interface">Interface utilisateur</message>
 
 <!--Wt-->
 <message id="Wt.WDateTime.LessThanASecond">moins d'une seconde</message>

diff --git a/approot/messages_it.xml b/approot/messages_it.xml
@@ -46,7 +46,7 @@
 <message id="Lms.Error.error-occurred">C'è stato un errore!</message>
 <message id="Lms.Error.go-home">Ritorna alla home</message>
 <message id="Lms.Error.release-not-found">Album non trovato</message>
-
+<message id="Lms.Error.tracklist-not-found">Playlist non trovata</message>
 <message id="Lms.Error.user-not-allowed">Non sei autorizzato ad eseguire questa operazione</message>
 <message id="Lms.Error.user-not-found">Utente non trovato</message>
 
@@ -289,7 +289,7 @@
 <!--Settings-->
 <message id="Lms.Settings.artist-release-sort-method">Metodo per ordinare gli album dell'artista</message>
 <message id="Lms.Settings.audio">Audio</message>
-<message id="Lms.Settings.audio-settings-are-local">Queste impostazioni sono salvate localmente su questo dispositivo!</message>
+<message id="Lms.Settings.audio-settings-are-local">Queste impostazioni sono salvate localmente su questo dispositivo</message>
 <message id="Lms.Settings.backend.internal">Interno</message>
 <message id="Lms.Settings.backend.listenbrainz">ListenBrainz</message>
 <message id="Lms.Settings.backend.listenbrainz-token">Token API ListenBrainz</message>
@@ -307,6 +307,7 @@
 <message id="Lms.Settings.original-date-desc">Data di uscita originale (Decrescente)</message>
 <message id="Lms.Settings.password-bad">Password errata</message>
 <message id="Lms.Settings.password-must-fill-old-password">Devi inserire la password attuale</message>
+<message id="Lms.Settings.regen-token">Genera</message>
 <message id="Lms.Settings.replaygain-mode">Modalità ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.none">No ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.auto">Automatica</message>
@@ -317,25 +318,27 @@
 <message id="Lms.Settings.scrobbling">Scrobbling</message>
 <message id="Lms.Settings.services">Servizi</message>
 <message id="Lms.Settings.settings">Impostazioni</message>
+<message id="Lms.Settings.settings-saved">Nuove impostazioni salvate!</message>
 <message id="Lms.Settings.subsonic-artist-list-mode">Modalità di elencazione artisti</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">Tutti gli artisti</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.release-artists">Artisti album</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.track-artists">Artisti tracce</message>
-<message id="Lms.Settings.subsonic-api">Subsonic API</message>
-<message id="Lms.Settings.user-interface">Interfaccia utente</message>
+<message id="Lms.Settings.subsonic-api">API Subsonic</message>
+<message id="Lms.Settings.subsonic-token">Chiave API OpenSubsonic</message>
+<message id="Lms.Settings.subsonic-token-usage">Utilizza questa chiave API come password per i client che non supportano l'estensione 'Autenticazione con chiave API'</message>
 <message id="Lms.Settings.transcoding">Transcodifica</message>
+<message id="Lms.Settings.transcoding-mode">Abilita transcodifica</message>
+<message id="Lms.Settings.transcoding-mode.always">Sempre</message>
+<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Quando il formato non è supportato</message>
+<message id="Lms.Settings.transcoding-mode.never">Mai</message>
 <message id="Lms.Settings.transcoding-output-bitrate">Bitrate transcodifica</message>
 <message id="Lms.Settings.transcoding-output-format">Formato di transcodifica</message>
 <message id="Lms.Settings.transcoding-output-format.matroska_opus">Matroska/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.mp3">MP3</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_opus">Ogg/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_vorbis">Ogg/Vorbis</message>
 <message id="Lms.Settings.transcoding-output-format.webm_vorbis">WebM/Vorbis</message>
-<message id="Lms.Settings.transcoding-mode">Abilita transcodifica</message>
-<message id="Lms.Settings.transcoding-mode.always">Sempre</message>
-<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Quando il formato non è supportato</message>
-<message id="Lms.Settings.transcoding-mode.never">Mai</message>
-<message id="Lms.Settings.settings-saved">Nuove impostazioni salvate!</message>
+<message id="Lms.Settings.user-interface">Interfaccia utente</message>
 
 <!--Wt-->
 <message id="Wt.WDateTime.LessThanASecond">meno di un secondo</message>

diff --git a/approot/messages_pl.xml b/approot/messages_pl.xml
@@ -315,7 +315,7 @@
 <!--Settings-->
 <message id="Lms.Settings.artist-release-sort-method">Metoda sortowania albumów artysty</message>
 <message id="Lms.Settings.audio">Dźwięk</message>
-<message id="Lms.Settings.audio-settings-are-local">Te ustawienia dotyczą wyłącznie tej przeglądarki!</message>
+<message id="Lms.Settings.audio-settings-are-local">Te ustawienia dotyczą wyłącznie tej przeglądarki</message>
 <message id="Lms.Settings.backend.internal">Wewnętrzny</message>
 <message id="Lms.Settings.backend.listenbrainz">ListenBrainz</message>
 <message id="Lms.Settings.backend.listenbrainz-token">ListenBrainz API token</message>
@@ -333,6 +333,7 @@
 <message id="Lms.Settings.original-date-desc">Oryginalna data wydania (Malejąco)</message>
 <message id="Lms.Settings.password-bad">Błędne hasło</message>
 <message id="Lms.Settings.password-must-fill-old-password">Należy podać stare hasło</message>
+<message id="Lms.Settings.regen-token">Generuj</message>
 <message id="Lms.Settings.replaygain-mode">Tryb ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.none">Bez ReplayGain</message>
 <message id="Lms.Settings.replaygain-mode.auto">Auto</message>
@@ -343,25 +344,27 @@
 <message id="Lms.Settings.scrobbling">Scrobbling</message>
 <message id="Lms.Settings.services">Usługi</message>
 <message id="Lms.Settings.settings">Ustawienia</message>
+<message id="Lms.Settings.settings-saved">Ustawienia zapisane!</message>
 <message id="Lms.Settings.subsonic-artist-list-mode">Tryb listy artystów</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.all-artists">Wszyscy artyści</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.release-artists">Artyści z albumów</message>
 <message id="Lms.Settings.subsonic-artist-list-mode.track-artists">Artyści ze ścieżek</message>
-<message id="Lms.Settings.subsonic-api">Subsonic API</message>
-<message id="Lms.Settings.user-interface">Interfejs użytkownika</message>
+<message id="Lms.Settings.subsonic-api">API Subsonic</message>
+<message id="Lms.Settings.subsonic-token">Klucz API OpenSubsonic</message>
+<message id="Lms.Settings.subsonic-token-usage">Użyj tego klucza API jako hasła dla klientów, którzy nie obsługują rozszerzenia 'Uwierzytelnianie za pomocą klucza API'</message>
 <message id="Lms.Settings.transcoding">Transkodowanie</message>
+<message id="Lms.Settings.transcoding-mode">Aktywuj transkodowanie</message>
+<message id="Lms.Settings.transcoding-mode.always">Zawsze</message>
+<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Tylko gdy przeglądarka nie wspiera formatu</message>
+<message id="Lms.Settings.transcoding-mode.never">Nigdy</message>
 <message id="Lms.Settings.transcoding-output-bitrate">Przepływność transkodowania</message>
 <message id="Lms.Settings.transcoding-output-format">Format wyjściowy transkodowania</message>
 <message id="Lms.Settings.transcoding-output-format.matroska_opus">Matroska/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.mp3">MP3</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_opus">Ogg/Opus</message>
 <message id="Lms.Settings.transcoding-output-format.ogg_vorbis">Ogg/Vorbis</message>
 <message id="Lms.Settings.transcoding-output-format.webm_vorbis">WebM/Vorbis</message>
-<message id="Lms.Settings.transcoding-mode">Aktywuj transkodowanie</message>
-<message id="Lms.Settings.transcoding-mode.always">Zawsze</message>
-<message id="Lms.Settings.transcoding-mode.if-format-not-supported">Tylko gdy przeglądarka nie wspiera formatu</message>
-<message id="Lms.Settings.transcoding-mode.never">Nigdy</message>
-<message id="Lms.Settings.settings-saved">Ustawienia zapisane!</message>
+<message id="Lms.Settings.user-interface">Interfejs użytkownika</message>
 
 <!--Wt-->
 <message id="Wt.WDateTime.LessThanASecond">mniej niż sekunda</message>