Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to 20 #115

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Update Node.js to 20 #115

merged 1 commit into from
Mar 23, 2024

Conversation

NotMyFault
Copy link
Contributor

@NotMyFault NotMyFault commented Feb 11, 2024

The change proposed updates Node.js from 16 to 20 to address the GH action deprecation warning.
Screenshot 2024-02-11 at 13 55 35

Fixes #114

I would appreciate a release after merge @eps1lon :)

Signed-off-by: Alexander Brandes <mc.cache@web.de>
Comment on lines -18 to +19
uses: actions/checkout@v3
- uses: actions/setup-node@v3
uses: actions/checkout@v4
- uses: actions/setup-node@v4
Copy link
Contributor Author

@NotMyFault NotMyFault Feb 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the underlying 16 -> 20 update but ensures workflows in this repository don't yield the same deprecation warning.

@stweil
Copy link

stweil commented Mar 23, 2024

I'd like to update bigbluebutton/bigbluebutton#19777 with a new release of actions-label-merge-conflict to fix the deprecated node issues. Is it possible to merge this pull request and tag a new release? Thanks!

Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why CI didn't run. Will check after merge and then do a release

@eps1lon eps1lon merged commit f18b7c4 into eps1lon:main Mar 23, 2024
@eps1lon
Copy link
Owner

eps1lon commented Mar 23, 2024

Released as eps1lon/actions-label-merge-conflict@v3. Thank you @NotMyFault

@NotMyFault NotMyFault deleted the node-20 branch March 23, 2024 16:31
@NotMyFault
Copy link
Contributor Author

Released as eps1lon/actions-label-merge-conflict@v3. Thank you @NotMyFault

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 16 actions are deprecated
3 participants