Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Address set-output deprecation #92

Merged
merged 1 commit into from
Oct 29, 2022
Merged

feat: Address set-output deprecation #92

merged 1 commit into from
Oct 29, 2022

Conversation

NotMyFault
Copy link
Contributor

@NotMyFault NotMyFault commented Oct 20, 2022 •
edited
Loading

The change proposed addresses the set-output deprecation of workflows: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The recommended upgrade step is to bump the core package.

cc jenkins-infra/helpdesk#3176 for my internal reference.

@MZole MZole mentioned this pull request Oct 25, 2022
Closed
@NotMyFault NotMyFault mentioned this pull request Oct 29, 2022
Merged
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@eps1lon eps1lon changed the title Address set-output deprecation feat: Address set-output deprecation Oct 29, 2022
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

eps1lon
eps1lon approved these changes Oct 29, 2022
View reviewed changes
Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon merged commit fd1f295 into eps1lon:main Oct 29, 2022
@NotMyFault NotMyFault deleted the set-output branch October 29, 2022 09:35
@NotMyFault
Copy link
Contributor Author

Thanks for the quick merge! Would you mind cutting a release of 2.1.0, please?

@eps1lon
Copy link
Owner

eps1lon commented Oct 29, 2022

2.1 should be part of main and 2.x. what is currently missing for you?

@NotMyFault
Copy link
Contributor Author

Does GitHub no longer demand a tag for actions to be consumed as the major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotMyFault @eps1lon