Ensure empty 2F text is ignored

eps1lon · Dec 31, 2022 · e562b75 · e562b75
1 parent cd69d4a
commit e562b75
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/sources/__tests__/accessible-name.js b/sources/__tests__/accessible-name.js
@@ -406,6 +406,7 @@ test.each([
  `<img data-test alt="" aria-label="a logo" role="presentation" /> />`,
  "a logo",
  ],
+ [` <input type="radio" data-test title="crazy"/>`, "crazy"],
 ])(`misc #%#`, (markup, expectedAccessibleName) => {
  expect(markup).toRenderIntoDocumentAccessibleName(expectedAccessibleName);
 });

diff --git a/sources/accessible-name-and-description.ts b/sources/accessible-name-and-description.ts
@@ -672,11 +672,14 @@ export function computeTextAlternative(
  isNativeHostLanguageTextAlternativeElement(current) ||
  isDescendantOfNativeHostLanguageTextAlternativeElement(current)
  ) {
- consultedNodes.add(current);
- return computeMiscTextAlternative(current, {
+ const accumulatedText2F = computeMiscTextAlternative(current, {
  isEmbeddedInLabel: context.isEmbeddedInLabel,
  isReferenced: false,
  });
+ if (accumulatedText2F !== "") {
+ consultedNodes.add(current);
+ return accumulatedText2F;
+ }
  }
 
  if (current.nodeType === current.TEXT_NODE) {