Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility name when title is empty #394

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

marcosvega91
Copy link
Contributor

fix #393

If the title is empty ( I have trimmed the text ) it is not considered as accessibility name.

I hope to have done something right :)

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2020

🦋 Changeset is good to go

Latest commit: 471cd81

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@eps1lon eps1lon added the bug Something isn't working label Aug 20, 2020
@eps1lon eps1lon merged commit fcc66ae into eps1lon:main Aug 20, 2020
@github-actions github-actions bot mentioned this pull request Aug 20, 2020
@marcosvega91 marcosvega91 deleted the pr/fix_acc_name_for_title branch August 20, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty title in button shadows name from content
2 participants