-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON API SysVar.deleteSysVarByName only softdeletes #118
Comments
Please show an example payload with example response output and not just explain your issues with words. Show concrete examples! |
Sure, payload for
Response is successful:
Payload for
Response is successful:
Asking for a non-existing variable would look like this:
Now the payload to create the variable again:
The response shows our variable was created with a new name to prevent the conflict with our soft-deleted one:
|
I am almost certain that the issue just happens because you have another object (device, channel, program, etc.) that has also the name "Test". Unfortunately, the |
JSON related quoting fixes and also modify the SysVar.* json methods to make sure that all these apply to system variable objects only and not generally to all objects throughout rega (programs, devices, etc.). This refs eq-3/occu#117 and eq-3/occu#118
It's definitly not because of "Test", my original Parameter was "APP_VENTILATION_STATUS". If you create, delete and recreate the same Systemvariable in the WebUI, the name won't add a number, it's only this behaviour with the JSON API. I think the SysVar methods for the JSON API are just not used very often, i guess most software will program the channels directly instead of using a system variable change to trigger programs. |
To reproduce create a new SysVar, e.g. using
SysVar.createEnum
named "Test". Now callSysVar.deleteSysVarByName
, the result shows success,SysVar.getAll
won't list the variable anymore. Now create "Test" again,SysVar.getAll
will show: it's listed as "Test 2", the original "Test" was only softdeleted. I couldn't figure out how to remove the original "Test" variable.Creating and deleting using the WebUI will not reproduce this behaviour.
Hardware: CCU3
Software: 3.65.6
The text was updated successfully, but these errors were encountered: