Skip to content

wip sync rework #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

wip sync rework #1090

wants to merge 1 commit into from

Conversation

Mirko-von-Leipzig
Copy link
Contributor

Looking for feedback on this wip sync redesign. Specifically, the async fn track() part (the rest is just me trying to think atm).

I'm trying to use futures instead of message / events.

@sergey-melnychuk
Copy link
Contributor

Interesting initiative! For me personally it is too early to give any meaningful feedback. I'd try to add some tests or even proceed in a TDD manner. When things get too tricky to test in a straightforward way, it is a sign of a necessary change (likely a new abstraction to be added). Once a working prototype (at leas basic sync is handled: new block is processed, no reorg, no "healing" etc) is ready (with meaningful test coverage), then providing feedback is going to be much easier, at least for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants