Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to the final Docker image #648

Closed
wants to merge 1 commit into from

Conversation

ClementWalter
Copy link

I would like to add curl to the final image because it is convenient for pulling snapshot of the database from within the running container.

@ClementWalter ClementWalter requested a review from a team as a code owner September 30, 2022 13:55
@kkovaacs
Copy link
Contributor

kkovaacs commented Oct 3, 2022

Can't we move that initialization to a separate container? Docker compose can provide something like K8S init containers via a service_completed_successfully dependency: docker/docs#12633

That way curl could be used to populate the data volume within the https://hub.docker.com/r/curlimages/curl image.

@ClementWalter
Copy link
Author

Yes definitely I tried to use alpine/curl to run a populate-{network}-data task before but I couldn't have this working with the docker<>ecs integration.

It's a bit frustrating because at first it seemed so easy to use but eventually very difficult to really make it work with a little more complexity in the docker-compose stack.

In any case I think you're right, so let's close this PR for now, and I may update my deployment scripts to avoid those docker<>ecs/azure integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants