-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Window Warning Fix #822
Conversation
This code is based entirely on the ANWW plugin with some minor refactor to remove need for JQuery and to avoid function nesting since it's already a module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- includes/classes/Fixes/Fix/AddNewWindowWarning.php: Language not supported
- includes/classes/Fixes/FixesManager.php: Language not supported
Comments skipped due to low confidence (2)
src/frontendFixes/Fixes/newWindowWarning.js:5
- [nitpick] The variable 'label' is reassigned multiple times within the 'updateAriaLabel' function. Consider using a local variable instead.
let label = '';
src/frontendFixes/Fixes/newWindowWarning.js:64
- The empty 'if' block at line 64 is unnecessary and should be removed to clean up the code.
if ( ! hasIcon ) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- includes/classes/Fixes/Fix/AddNewWindowWarning.php: Language not supported
- includes/classes/Fixes/FixesManager.php: Language not supported
Comments skipped due to low confidence (1)
src/frontendFixes/Fixes/newWindowWarning.js:3
- [nitpick] The variable name 'localizedOpenString' is ambiguous. It should be renamed to 'localizedNewWindowWarning' to better reflect its purpose.
const localizedOpenString = __( 'opens a new window', 'accessibility-checker' );
…w tabs fix is enabled
Co-authored-by: Steve Jones <steve@stevejonesdev.com>
This adds a fix for new window warnings. It is based entirely on the same feature from the ANWW plugin with some refactoring.
Checklist