Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non English chars are not correctly displayed for text output file #12

Closed
it-praktyk opened this issue Aug 14, 2016 · 4 comments · Fixed by #18
Closed

Non English chars are not correctly displayed for text output file #12

it-praktyk opened this issue Aug 14, 2016 · 4 comments · Fixed by #18
Labels

Comments

@it-praktyk
Copy link
Collaborator

Like on the screenshot below - Polish chars are not correctly displayed - but only for text format.
format-pester-text-results-for-polish

The example based on the version 1.3.0 - the pull request #10

CC: @iainbrighton

@it-praktyk
Copy link
Collaborator Author

I've checked encoding of file containing Polish translation - UTF-8 is used.

@equelin equelin added the bug label Aug 16, 2016
@it-praktyk
Copy link
Collaborator Author

I've analyzed the code of PScribo

## Text encoding
[Parameter(ValueFromPipelineByPropertyName)]
[ValidateSet('ASCII','Unicode','UTF7','UTF8')]
[System.String] $Encoding = 'ASCII'

Source:

Looks like that encoding parameter should be added to translations files also.

Maybe I missed something but encoding is only used for text output. @iainbrighton, am I right?

@iainbrighton
Copy link

@it-praktyk The Encoding option is only used for the Text plugin. By default, ASCII encoding is used. Are you saying that the generated text file is in UTF8 encoding by default? For those Polish characters, will UTF8 format work or will you need Unicode?

@it-praktyk
Copy link
Collaborator Author

@ianbrighton,

  • Polish letters can be encoded by UTF8 also
  • the file what contains Polish translation is encoded by UTF8, not the result files

I know that I can add Encoding to the section but I don't understand (is it too late or I'm too tired?) why a double hash table construction is used. Can you help me directly?

it-praktyk added a commit to it-praktyk/Format-Pester that referenced this issue Sep 4, 2016
it-praktyk added a commit to it-praktyk/Format-Pester that referenced this issue Sep 5, 2016
it-praktyk added a commit to it-praktyk/Format-Pester that referenced this issue Sep 5, 2016
…ded - resolved equelin#15, the test for translations corrected, documentation updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants