add minMargin buffer in vault

equilibria-xyz · Sep 4, 2023 · 89efc21 · 89efc21
1 parent 6d192cc
commit 89efc21
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/perennial-vault/contracts/lib/StrategyLib.sol b/packages/perennial-vault/contracts/lib/StrategyLib.sol
@@ -77,10 +77,10 @@ library StrategyLib {
                 .muldiv(registrations[marketId].weight, totalWeight)
                 .min(_locals.marketCollateral.mul(LEVERAGE_BUFFER));
 
-            if (
-                contexts[marketId].marketParameter.closed ||
-                _locals.marketAssets.lt(contexts[marketId].riskParameter.minMargin)
-            ) _locals.marketAssets = UFixed6Lib.ZERO;
+            UFixed6 minAssets = contexts[marketId].riskParameter.minMargin
+                .unsafeDiv(registrations[marketId].leverage.mul(contexts[marketId].riskParameter.maintenance));
+            if (contexts[marketId].marketParameter.closed || _locals.marketAssets.lt(minAssets))
+                _locals.marketAssets = UFixed6Lib.ZERO;
 
             (_locals.minPosition, _locals.maxPosition) = _positionLimit(contexts[marketId]);
 

diff --git a/packages/perennial-vault/test/integration/vault/Vault.test.ts b/packages/perennial-vault/test/integration/vault/Vault.test.ts
@@ -205,6 +205,7 @@ describe('Vault', () => {
       oracle: rootOracle.address,
       payoff: constants.AddressZero,
       makerLimit: parse6decimal('1000'),
+      minMargin: parse6decimal('50'),
       minMaintenance: parse6decimal('50'),
       maxLiquidationFee: parse6decimal('25000'),
     })
@@ -214,6 +215,7 @@ describe('Vault', () => {
       owner: owner,
       oracle: btcRootOracle.address,
       payoff: constants.AddressZero,
+      minMargin: parse6decimal('50'),
       minMaintenance: parse6decimal('50'),
       maxLiquidationFee: parse6decimal('25000'),
     })